the clip comes in handy because it can clip to a zipper or whatever, but the keyring is lighter weight, from my sales so far it's been really hard to tell what people prefer. and I like having stuff ready-made, and I can't switch them out once it's done you know?
How about you do one of each and put both in the shop. Then they are ready to ship and the customer can choose. And more items probably means more sales!
i like both, but the lobster clip would be really convenient because you don't have to fumble around with key rings! plus you could attach it to more things...